Make it clearer that the suggestion is an alternative one #13390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`needless_pass_by_value` sometimes suggest marking the concerned type as `Copy`. Adding a `or` before this suggestion makes it clearer that this is not the second part of the original suggestion, but an alternative one.
rustbot
added
the
S-waiting-on-review
xFrednet
approved these changes
Sep 12, 2024
|
LGTM, thank you for the improvement :D Roses are red, |
bors
added a commit
that referenced
this pull request
Sep 12, 2024
Make it clearer that the suggestion is an alternative one `needless_pass_by_value` sometimes suggest marking the concerned type as `Copy`. Adding a `or` before this suggestion makes it clearer that this is not the second part of the original suggestion, but an alternative one. Inspired by a misunderstanding in #13321
|
💔 Test failed - checks-action_test |
|
@xFrednet Forgot the changelog: none, now added. |
|
@bors retry |
|
Happens to the best of us :D |
|
💡 This pull request was already approved, no need to approve it again. |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needless_pass_by_valuesometimes suggest marking the concerned type asCopy. Adding aorbefore this suggestion makes it clearer that this is not the second part of the original suggestion, but an alternative one.Inspired by a misunderstanding in #13321
changelog: none